Repository navigation
Conversation
…sion pruneManagedVersions kept the newest older release unconditionally. When that release is below CLOUDFLARED_MIN_VERSION, resolve() can never use it, so it sat on disk forever. Keep the newest older release only when it is still compatible and remove the rest.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Problem
pruneManagedVersionskeeps the newest older managed cloudflared release unconditionally (olderManagedVersions.slice(1)). When that release is belowCLOUDFLARED_MIN_VERSION,resolve()rejects it, so it can never run: it is disk kept for a rollback that cannot happen. Withtools/cloudflared/2026.10.0beside the pinned2026.10.4and a minimum of2026.10.3,2026.10.0is retained forever.This is the cloudflared path from #40805 that #40817 intentionally left unchanged.
Change
CLOUDFLARED_MIN_VERSION; remove every older release that cannot run.2026.10.4and an outdated2026.10.0; it fails onmain(the outdated directory survives) and passes with the change. Updated the existing rollback test to keep a compatible2026.10.3and prune a below-minimum2026.10.2.Scope
Bug fix in
packages/sharedonly. Related to #40805, whose runtime and staging paths are fixed by #40817.chrome-headless-shellstill keeps one previous copy, as #40817 states; this PR does not touch it. No UI changes.Verification
vp test run packages/shared/src/relayClient.test.ts— 21 passed.mainwith the outdated release still present, and passes with the fix.vp run check:changed— format, lint, knip, typecheck (37 packages), and tests all pass.Made with DeepSeek V4.1 Flash in T3 Code.